Add strtolower on IDE format lookup against input to make it friendlier#3187
Merged
magento-team merged 1 commit intomagento:developfrom Mar 12, 2016
Merged
Conversation
Contributor
|
Internal ticket created: MAGETWO-49727 |
Contributor
|
Thank you @MartinPeverelli, we'll process this internally |
sshrewz
added
the
Issue: Ready for Work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently user needs to input exact format param, properly cased, for the dev:urn-catalog:generate command to work.
This small tweak uses strtolower in order to format the user input so strings like "PhpStorm", "PHPStorm", "PHPSTORM" are now all valid.
The reason for this proposed update is that PhpStorm by default always suggests PHPSTORM as the key for the IDE on different uses (a common example is xdebug).
This change is transparent to the end user, and to the rest of the codebase.