Skip to content

Conversation

@amenk
Copy link
Contributor

@amenk amenk commented Jun 26, 2013

Most Mage core code and module use log() very seldomly, not for real debug messages.
Setting this to info would allow us to log also real debug info.

Most Mage core code and module use log() very seldomly, not for real debug messages.
Setting this to info would allow is to log also real debug info.
@verklov
Copy link
Contributor

verklov commented Nov 7, 2013

Hello amenk,
Sorry for the delay with the response.
Thank you for your contribution! Our team will review your pull request and respond as soon as our analysis is complete.

@verklov
Copy link
Contributor

verklov commented Dec 1, 2013

Hello amenk,
We cannot accept your pull request.
There is no reason to change default argument value in Logger::log() (god-class Mage no longer exists), because there will be no big difference in logged data.
As you may see in addStreamLog() in /lib/Magento/Logger.php the format of log is strictly defined and according to it this change is useless.
However if you still need to customize your logs you can add your own logger into the system, Magento allows that and provides such ability.
Nevertheless, thank you for your contribution and participation in the Magento product development!

@verklov verklov closed this Dec 1, 2013
magento-team pushed a commit that referenced this pull request May 22, 2015
[MPI] Magento  module removal - fix integration test
okorshenko pushed a commit that referenced this pull request Jan 20, 2016
Magento 2.0.1 Publication
okorshenko pushed a commit that referenced this pull request Dec 14, 2016
Fixed issues:
- MAGETWO-56977: CLONE- Unable to setup Magento via web installer for 2.1.x
- MAGETWO-57052: [Backport] - Cannot import negative quantity - for 2.1
- MAGETWO-57351: [Backport] - Example password enocurages password reuse - for 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants