Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration for Stale Issue bot #30095

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Added configuration for Stale Issue bot #30095

merged 1 commit into from
Sep 23, 2020

Conversation

sdzhepa
Copy link
Contributor

@sdzhepa sdzhepa commented Sep 17, 2020

Description

This PR adds configuration for the GitHub application https://probot.github.io/apps/stale/

This application will label stale issues, comment, and close if no further activities occur.
Please see the official README.md of the application owner for more details.

The Goal is Keep the Issue Backlog healthy and up to date

  • it will be applied on the Issue only, PRs will not be commented and processed as stale

Example of work

  1. An Issue was reported and does not have activity for XX days defined in daysUntilStale configuration.
    -- daysUntilStale: 76
  2. Stale-bot is starting processing this issue.
  3. Stale-bot checks if an Issue has any label from the exclude list defined in exemptLabels configuration.
    If Yes, the issue will NOT be processed as stale:
    -- If Issue is critical (P0, P1, P2)
    -- If Issue is in progress or has opened Pull Request
    -- if Issue related to an additional or special project
exemptLabels:
  - "Priority: P0"
  - "Priority: P1"
  - "Priority: P2"
  - "Progress: dev in progress"
  - "Progress: PR in progress"
  - "Progress: done"
  - "B2B: GraphQL"   
  - "Progress: PR Created"
  - "PAP"
  - "Project: Login as Customer"
  - "Project: GraphQL"
  1. Stale-bot marks Issue with lable defined in staleLabel config
    -- staleLabel: "stale issue"

  2. Stale-bot posts a comment defined in markComment config
    -- This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

  3. Issue will be labeled and commented as stale during the next XX days defined in daysUntilClose.
    If no new activities appear, Stale-bot will close this Issue.
    -- daysUntilClose: 14

@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2020

Hi @sdzhepa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Sep 17, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8231 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 18, 2020
@sdzhepa
Copy link
Contributor Author

sdzhepa commented Sep 22, 2020

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2020

Hi @sdzhepa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev
Copy link
Contributor

@sdzhepa @sivaschenko @gabrieldagama does it mean this configuration started working after merging this PR?

@okorshenko
Copy link
Contributor

okorshenko commented Sep 23, 2020

Hi @ihor-sviziev
No, we will install the application later. We need to do proper communitycation on that. I will DM you on that
And Thank You for your proposal on Stale issue app and pushing this forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants