Fix of Asynchronous opetations status issue #29814

nuzil · 2020-08-31T08:27:44Z

Description (*)

Fix of Asynchronous opetations status issue. When using MYSQL Async queues. Caused by provided in 2.4 release new database field, which is not required to have for Mysql queues.

Fixed Issues (if relevant)

Fixes Wrong handling some of asynchronous bulk operations and related mysql queue messages in Magento 2.4.0 #29718

Manual testing scenarios (*)

See Issue.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

for support B2B implementations

…g bulk operation with not set 'operation_id' during executing \Magento\Catalog\Model\Attribute\Backend\Consumer::process() method.

m2-assistant · 2020-08-31T08:27:47Z

Hi @nuzil. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rogyar · 2020-08-31T12:41:35Z

dev/tests/integration/testsuite/Magento/Catalog/Model/Attribute/Backend/ConsumerTest.php

+            ]
+        );
+        $this->bulkStatus = $this->objectManager->get(BulkStatus::class);
+        $catalogProductMock = $this->createMock(\Magento\Catalog\Helper\Product::class);


Hi @nuzil. What do you think about using imports everywhere instead of FQN? Currently, we use both. But I believe we may make the code a little bit more readable by using the same approach for all places.

Just a minor suggestion

rogyar · 2020-08-31T12:42:31Z

@magento run all tests

VladimirZaets · 2020-08-31T13:52:44Z

@magento I am working on it

ghost · 2020-08-31T13:53:02Z

@m2-assistant[bot] unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

VladimirZaets · 2020-08-31T14:10:11Z

@magento I am working on it

VladimirZaets · 2020-08-31T14:13:28Z

@magento I am working on it

ghost · 2020-08-31T14:21:39Z

@m2-assistant[bot] unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

VladimirZaets · 2020-08-31T14:48:13Z

@magento I am working on it

nuzil · 2020-09-15T08:13:43Z

@engcom-Charlie
Looks like failed tests are not connected to PR

magento-engcom-team · 2020-09-21T10:20:53Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-8108 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Alfa · 2020-09-21T11:01:14Z

✔️ QA Passed

✔️ Displayed messages like "1 item(s) have been successfully updated...".

✔️ Attribute values for related products updated.
✔️ New record(s) in the "queue_message" (related to the queues "product_action_attribute.update" and/or product_action_attribute.website.update) and new related record(s) in the "queue_message_status" table with status "4".

✔️ No errors in system.log file

m2-assistant · 2020-09-23T12:33:12Z

Hi @nuzil, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

nuzil and others added 3 commits July 3, 2020 09:48

Set up operation_key as nullable

09b63c7

for support B2B implementations

Merge branch '2.4-develop' into async-opetation-status-issue

2450b14

async-opetation-status-issue Added intagration test for testing savin…

77d62ef

…g bulk operation with not set 'operation_id' during executing \Magento\Catalog\Model\Attribute\Backend\Consumer::process() method.

ghost added the Progress: pending review label Aug 31, 2020

magento-engcom-team added Component: AsynchronousOperations Release Line: 2.4 Partner: Comwrap partners-contribution Pull Request is created by Magento Partner labels Aug 31, 2020

rogyar self-assigned this Aug 31, 2020

rogyar reviewed Aug 31, 2020

View reviewed changes

m2-assistant bot assigned VladimirZaets Aug 31, 2020

ghost unassigned VladimirZaets Aug 31, 2020

m2-assistant bot assigned VladimirZaets Aug 31, 2020

ghost unassigned VladimirZaets Aug 31, 2020

m2-assistant bot assigned VladimirZaets Aug 31, 2020

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Aug 31, 2020

sidolov previously approved these changes Aug 31, 2020

View reviewed changes

magento-engcom-team assigned sidolov Aug 31, 2020

ghost removed the Progress: pending review label Aug 31, 2020

engcom-Charlie requested review from sidolov and rogyar September 17, 2020 13:14

ghost added Progress: review and removed Progress: needs update labels Sep 17, 2020

gabrieldagama approved these changes Sep 21, 2020

View reviewed changes

ghost assigned gabrieldagama Sep 21, 2020

ghost added Progress: ready for testing and removed Progress: review labels Sep 21, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 21, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 21, 2020

ghost added Progress: accept and removed Progress: extended testing labels Sep 21, 2020

gabrieldagama added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 21, 2020

gabrieldagama mentioned this pull request Sep 23, 2020

Wrong handling some of asynchronous bulk operations and related mysql queue messages in Magento 2.4.0 #29718

Closed

5 tasks

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2020

ENGCOM-8108: Fix of Asynchronous opetations status issue #29814

84bceaa

magento-engcom-team merged commit 1455b3d into magento:2.4-develop Sep 23, 2020

hostep mentioned this pull request Sep 24, 2020

"Pending, in queue" message remain even after bulk action - update of product attributes is done #29797

Closed

hostep mentioned this pull request Oct 6, 2020

New bulk schedule doesn't create operations automatically #23958

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix of Asynchronous opetations status issue #29814

Fix of Asynchronous opetations status issue #29814

nuzil commented Aug 31, 2020

m2-assistant bot commented Aug 31, 2020

rogyar Aug 31, 2020

rogyar commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

ghost commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

ghost commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

nuzil commented Sep 15, 2020

magento-engcom-team commented Sep 21, 2020

engcom-Alfa commented Sep 21, 2020

m2-assistant bot commented Sep 23, 2020

Fix of Asynchronous opetations status issue #29814

Fix of Asynchronous opetations status issue #29814

Conversation

nuzil commented Aug 31, 2020

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

m2-assistant bot commented Aug 31, 2020

rogyar Aug 31, 2020

Choose a reason for hiding this comment

rogyar commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

ghost commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

ghost commented Aug 31, 2020

VladimirZaets commented Aug 31, 2020

nuzil commented Sep 15, 2020

magento-engcom-team commented Sep 21, 2020

engcom-Alfa commented Sep 21, 2020

m2-assistant bot commented Sep 23, 2020