-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#257: create new id_v2 option #28210
#257: create new id_v2 option #28210
Conversation
Hi @mmezhensky. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento run Static Tests |
1 similar comment
@magento run Static Tests |
...o/ConfigurableProductGraphQl/Model/Resolver/Variant/Attributes/ConfigurableAttributeIdV2.php
Outdated
Show resolved
Hide resolved
d5a6091
to
d8d7d83
Compare
Looks good to me. Let's wait for the final decision regarding the bundle product options with quantity |
@magento run all tests |
Looks good! Thank you @eduard13 |
Hi @mmezhensky, thank you for your contribution! |
Description (*)
This PR extends product schema and added new identifier "id_v2"
Solution Architecture
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
selected_options
,entered_options
), because both cases have a conflicting return type forvalue
.Contribution checklist (*)