magento/magento2#: Add a new index for cron_schedule table

[atwixfirster]

Description (*)

Magento\Cron\Model\ResourceModel\Schedule::trySetJobStatusAtomic() executes an UPDATE SQL with an additional status parameter:

 UPDATE `cron_schedule` SET `status` = ? WHERE (schedule_id = ?) AND (status = ?) 

UPDATE is a hard query and New Relic report about this:

PR adds an additional index based on

• schedule_id
• status

fields.

Related Pull Requests

Fixed Issues (if relevant)

1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] magento/magento2#: Add a new index for cron_schedule table #29601: magento/magento2#: Add a new index for cron_schedule table

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[kandy]

Query that you show use "where" condition on primary keys and so should run with a millisecond performance

See

mysql> UPDATE `cron_schedule` SET `status` = 'run' WHERE (schedule_id = 1153)  AND (status = 'pending');
Query OK, 1 row affected (0.02 sec)
Rows matched: 1  Changed: 1  Warnings: 0

mysql> DESC UPDATE `cron_schedule` SET `status` = 'pending' WHERE (schedule_id = 1)  AND (status = 'pending');
+----+-------------+---------------+------------+-------+---------------+---------+---------+-------+------+----------+-------------+
| id | select_type | table         | partitions | type  | possible_keys | key     | key_len | ref   | rows | filtered | Extra       |
+----+-------------+---------------+------------+-------+---------------+---------+---------+-------+------+----------+-------------+
|  1 | UPDATE      | cron_schedule | NULL       | range | PRIMARY       | PRIMARY | 4       | const |    1 |   100.00 | Using where |
+----+-------------+---------------+------------+-------+---------------+---------+---------+-------+------+----------+-------------+
1 row in set (0.00 sec)

[kandy]

Can you add database version and explain for this query ?

[atwixfirster]

Hi, @kandy !

Can you add database version and explain for this query ?

Magento Cloud staging environment.

DB version = 10.0.38-MariaDB-1~jessie-wsrep

Table cron_schedule contains ~15 000 records.

[atwixfirster]

UPDATE here:

Today, I've analyzed New Relic reports and detected that a new index did not help to reduce UPDATE execution time.

In the same time, I've changed a logic of Magento\Cron\Model\ResourceModel\Schedule::trySetJobStatusAtomic():

public function trySetJobStatusAtomic($scheduleId, $newStatus, $currentStatus)
    {
        $connection = $this->getConnection();
        $select = $connection->select()
            ->from(
                $this->getTable('cron_schedule'),
                [
                    'status'
                ]
            )->where(
                'schedule_id = ?', $scheduleId
            );
        $resultRow = $connection->fetchRow($select);

        $result = false;
        if ($resultRow['status'] != $newStatus) {
            $result = $connection->update(
                $this->getTable('cron_schedule'),
                ['status' => $newStatus],
                ['schedule_id = ?' => $scheduleId]
            );
        }

        return (bool)$result;
    }

The mentioned approach helped to reduce UPDATE queries calls.

[engcom-Alfa]

Hi @kandy . Could you put an appropriate label for test coverage?
Thanks!

[engcom-Alfa]

Hi @atwixfirster . We have some problems with checkout to your branch. Could you update it?
Thanks!

[engcom-Charlie]

Hi, @sidolov can you please review this PR?
Thank you.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8164 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

A new index for cron_schedule table was successfully added and everything works as expected.

[hostep]

Before this gets merged, can somebody confirm that this won't conflict with #28007 ?

[kandy]

I can confirm that it will conflict as it duplicate to #28007?

[m2-assistant]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

@sidolov @gabrieldagama i believe this should be reverted in favor to #28007 that does the same and was approved more than 2 weeks ago