Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to '%context%' (dead code) #26900

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Removed references to '%context%' (dead code) #26900

merged 2 commits into from
Apr 4, 2020

Conversation

markshust
Copy link
Contributor

Description (*)

Magento\Framework\RequireJs\Config has a call to str_replace for %context% reference, which doesn't exist.

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

All references to create RequireJS config from config variables should contain same output as before update, since there are no references to %context% in backen logic.

Questions or comments

Dead code elimination

Contribution checklist (*)

  • [ x ] Pull request has a meaningful description of its purpose
  • [ x ] All commits are accompanied by meaningful commit messages
  • [ x ] All new or changed code is covered with unit/integration tests (if applicable)
  • [ x ] All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 17, 2020

Hi @markshust. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Feb 18, 2020
@rogyar
Copy link
Contributor

rogyar commented Feb 18, 2020

Good catch.
I see no "context" occurrence as well. Maybe there was some idea behind it at the very beginning of the platform development but then the architecture has been changed.

@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 18, 2020
@ihor-sviziev ihor-sviziev self-assigned this Apr 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7252 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit 30f02cc into magento:2.4-develop Apr 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @markshust, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@markshust markshust deleted the feature/removed-references-to-context-dead-code branch July 28, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants