-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed references to '%context%' (dead code) #26900
Removed references to '%context%' (dead code) #26900
Conversation
Hi @markshust. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Good catch. |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed |
Hi @markshust, thank you for your contribution! |
Description (*)
Magento\Framework\RequireJs\Config
has a call tostr_replace
for%context%
reference, which doesn't exist.Related Pull Requests
N/A
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
All references to create RequireJS config from config variables should contain same output as before update, since there are no references to
%context%
in backen logic.Questions or comments
Dead code elimination
Contribution checklist (*)