Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASI #Issue-723 Fixed the issue: "Image preview should be closed when the page is changed" #25719

Conversation

serhiyzhovnir
Copy link

Description (*)

This PR fixes the issue magento/adobe-stock-integration#723: Image preview should be closed when the page is changed.
issue-723

Fixed Issues (if relevant)

  1. Image preview should be closed when the page is changed adobe-stock-integration#723: Image preview should be closed when the page is changed

Manual testing scenarios (*)

  1. Login to admin panel
  2. Navigate to Cms Pages
  3. User clicks Add New Page button
  4. Expand "Content" section
  5. User clicks "Insert Image..." button
  6. Click "Search Adobe Stock" button to open images grid
  7. Click on an first image to expand the preview on first page
  8. Change grid page.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 24, 2019

Hi @serhiyzhovnir. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Ui Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 24, 2019
@rogyar rogyar self-assigned this Nov 24, 2019
@rogyar
Copy link
Contributor

rogyar commented Nov 24, 2019

Hi @serhiyzhovnir. Thank you for your contribution. As far as I remember, we had this point covered in the original fix. I'm not sure why the paging listener has been removed, but maybe it was done for a purpose. I just want to make sure that we didn't miss anything.
@sivaschenko if you have more information on this matter, please, provide your expertise.

Thank you!

@sivaschenko
Copy link
Member

Hi @rogyar @serhiyzhovnir , I think the paging listener was accidentally removed during the merge or synchronization between adobe-stock-integration and magento2 repository was inaccurate. In either case that appears to be my mistake, sorry for that.

@sivaschenko
Copy link
Member

Covered with functional tests in Adobe Stock Integration project

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-6323 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

magento-engcom-team pushed a commit that referenced this pull request Nov 26, 2019
@magento-engcom-team magento-engcom-team merged commit f307e2e into magento:2.3-develop Nov 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2019

Hi @serhiyzhovnir, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.5 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: ready for testing Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants