-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASI #Issue-723 Fixed the issue: "Image preview should be closed when the page is changed" #25719
ASI #Issue-723 Fixed the issue: "Image preview should be closed when the page is changed" #25719
Conversation
Hi @serhiyzhovnir. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @serhiyzhovnir. Thank you for your contribution. As far as I remember, we had this point covered in the original fix. I'm not sure why the paging listener has been removed, but maybe it was done for a purpose. I just want to make sure that we didn't miss anything. Thank you! |
Hi @rogyar @serhiyzhovnir , I think the paging listener was accidentally removed during the merge or synchronization between |
Covered with functional tests in Adobe Stock Integration project |
Hi @sivaschenko, thank you for the review. |
✔️ QA passed |
… closed when the page is changed" #25719
Hi @serhiyzhovnir, thank you for your contribution! |
Description (*)
This PR fixes the issue magento/adobe-stock-integration#723: Image preview should be closed when the page is changed.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)