Resolve "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run) #25033

[edenduong]

Description (*)

1. Resolve "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run) #25033: "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run)

Fixed Issues (if relevant)

1. "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run) #25033: "New Accounts Report" should disable the sort ability of "New Account" columns (because it can not run)

Manual testing scenarios (*)

1. Go to backend
2. Reports-> Customers-> New
3. Show report
4. Click "New Account" column
   => Disable sort, no reload page

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

Hello @edenduong,
did you investigate the reason why the sorting does not work for customer report grids?
It might be possible to fix the not working sort order for customer reports collections.

Thank you!

[edenduong]

Hi @dmytro-ch : the main reason is all the report in the magento backend can not be sort too.
The second reason is Some record are string like “No record found ...”, some record are the number (1,2,3...) so I think it is not the same data type and can not be sortable.

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6104 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[engcom-Foxtrot]

Covering