magento/magento2#: Replace deprecated Magento\Customer\Model\Customer::isConfirmationRequired method#24334
Conversation
|
Hi @atwixfirster. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
98729bf to
1d039e5
Compare
dmytro-ch
left a comment
There was a problem hiding this comment.
@atwixfirster, could you please also update the unit test for the session model?
There was a problem hiding this comment.
Please, keep as it is.
Just ignore this rule:
// phpcs:ignore Magento2.Security.InsecureFunction
There was a problem hiding this comment.
…::isConfirmationRequired method
1d039e5 to
3d03cb4
Compare
|
Hi @atwixfirster |
|
Hi @atwixfirster, thank you for your contribution! |
Description (*)
During new customer registration
Magento\Customer\Model\ResourceModel\Customermodel uses deprecatedMagento\Customer\Model\Customer::isConfirmationRequiredin the_beforeSave()method.Fixed Issues (if relevant)
Manual testing scenarios (*)
Preconditions
Require Emails Confirmationoption toYeson back-end sideSteps to reproduce
Create new customer
You will get a confirmation link in the email
Expected result: customer should get a confirmation email
Questions or comments
Contribution checklist (*)
Thank you!