Resolve No validate "Proxy Port" in Paypal Module (Paypal Express, Paypal Payflow -Link, Pro, Advanced) issue24304

[edenduong]

Description (*)

1. Resolve No validate "Proxy Port" in Paypal Module (Paypal Express, Paypal Payflow -Link, Pro, Advanced) #24304: No validate "Proxy Port" in Paypal Module (Paypal Express, Paypal Payflow -Link, Pro, Advanced)

Solution: Add "validate-digits validate-zero-or-greater" in .xml file

Fixed Issues (if relevant)

1. No validate "Proxy Port" in Paypal Module (Paypal Express, Paypal Payflow -Link, Pro, Advanced) #24304: No validate "Proxy Port" in Paypal Module (Paypal Express, Paypal Payflow -Link, Pro, Advanced)

Manual testing scenarios (*)

1. Go to backend
2. Store->Configurations
3. Sales-> Payment Methods
4. "API Uses Proxy" in Paypal Express, Paypal Payflow, Paypal Pro is "Yes"
5. "Proxy Port" fill "one"
6. Save

Expected result

1. Can not save because it is not number

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[swnsma]

Hi @edenduong,

Thank you for your contribution!
Can we use range for validation of port value (tap) instead of validate-zero-or-greater ?

[edenduong]

Hi @edenduong,

Thank you for your contribution!
Can we use range for validation of port value (tap) instead of validate-zero-or-greater ?

Thank you for your reviewing. I have change the source code to validate the range 0-65535

Thank you.

[swnsma]

Hi @edenduong,
Thank you for your contribution!
Can we use range for validation of port value (tap) instead of validate-zero-or-greater ?

Thank you for your reviewing. I have change the source code to validate the range 0-65535

Thank you.

Great!
Thank you!

[magento-engcom-team]

Hi @swnsma, thank you for the review.
ENGCOM-5719 has been created to process this Pull Request

[dmytro-ch]

Hi @edenduong,
please, combine the pull requests with such improvements in one single pull request on order make it easier to process these PRs by Community Engineering Team.
#24313
#24309
#24303
#24305
Also, feel free to create pull requests for minor fixes and obvious improvements without opening the issues.

Thank you!

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @edenduong
Thank you for your contribution. This pull request has been combined (merged) with #24313 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.