Correct the return of type of function _columnBrake in module-theme block topMenu.php#24252
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Aug 28, 2019
Krielkip:2.3-develop
Merged
Correct the return of type of function _columnBrake in module-theme block topMenu.php#24252magento-engcom-team merged 2 commits intomagento:2.3-developfrom Krielkip:2.3-develop
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
Krielkip:2.3-develop
Conversation
Import changes
Function _columnBrake return null when limit is smaller then $total. But _getHtml needs the result to be array.
|
Hi @Krielkip. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
sidolov
approved these changes
Aug 23, 2019
Contributor
|
Hi @sidolov, thank you for the review.
|
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 28, 2019
…odule-theme block topMenu.php #24252
|
Hi @Krielkip, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Function _columnBrake return null when limit is smaller then $total.
But _getHtml needs the result to be array, which is being called in _getSubmenu.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)