Skip to content

Correct the return of type of function _columnBrake in module-theme block topMenu.php#24252

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
Krielkip:2.3-develop
Aug 28, 2019
Merged

Correct the return of type of function _columnBrake in module-theme block topMenu.php#24252
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
Krielkip:2.3-develop

Conversation

@Krielkip
Copy link
Copy Markdown
Contributor

@Krielkip Krielkip commented Aug 23, 2019

Description (*)

Function _columnBrake return null when limit is smaller then $total.
But _getHtml needs the result to be array, which is being called in _getSubmenu.

Fixed Issues (if relevant)

  1. Module-Theme: TopMenu invalid type of value returned #24251: Module-Theme: TopMenu invalid type of value returned

Manual testing scenarios (*)

  1. Code review the functions: _columnBrake, _addSubMenu and _getHtml

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Function _columnBrake return null when limit is smaller then $total.
But _getHtml needs the result to be array.
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Aug 23, 2019

Hi @Krielkip. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost ghost assigned sidolov Aug 23, 2019
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5686 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Aug 28, 2019

Hi @Krielkip, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 28, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants