Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clean_cache plugin flush mode #22336

Merged
merged 1 commit into from
Jun 7, 2019
Merged

fix clean_cache plugin flush mode #22336

merged 1 commit into from
Jun 7, 2019

Conversation

thomas-kl1
Copy link
Member

Previous PR: #20228

The following plugin is used to clean the "block_html" and "collections" cache types by tags.
This plugin is not really used in the native Magento app, so I guess no one didn't really had issue with it (unless for eav resource models).

The \Zend_Cache::CLEANING_MODE_MATCHING_TAG is too restrictive as all entity tags must match with the stored data tags.

Description (*)

  • introduce strict types
  • fix clean cache mode to match any tags

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @thomas-kl1. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

@thomas-kl1 trying to reopen old one as branch seems to be the same.

@orlangur orlangur closed this Apr 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @thomas-kl1, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@orlangur orlangur reopened this Apr 15, 2019
@ghost ghost unassigned orlangur Apr 15, 2019
@orlangur
Copy link
Contributor

image
image

Damn it :)

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomas-kl1! Didn't expect changes applied that fast 😉

@thomas-kl1
Copy link
Member Author

@orlangur yep that's why i've created a new one haha, don't know what the process should be

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-4757 has been created to process this Pull Request

@Nazar65
Copy link
Member

Nazar65 commented May 8, 2019

QA Passed ✔️

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request Jun 7, 2019
@magento-engcom-team magento-engcom-team merged commit fcea053 into magento:2.3-develop Jun 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2019

Hi @thomas-kl1, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 7, 2019
@drew7721
Copy link
Member

Can you link related issues that caused this PR and fix?

@thomas-kl1
Copy link
Member Author

There is no related issues link.
I did the fix because I was playing with collection cache and IdentityInterface, and seen that an invalidate cache for a model wasn't cleaning the collection cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants