-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clean_cache plugin flush mode #22336
fix clean_cache plugin flush mode #22336
Conversation
Hi @thomas-kl1. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@thomas-kl1 trying to reopen old one as branch seems to be the same. |
Hi @thomas-kl1, thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thomas-kl1! Didn't expect changes applied that fast 😉
@orlangur yep that's why i've created a new one haha, don't know what the process should be |
Hi @orlangur, thank you for the review. |
QA Passed ✔️ |
Hi @thomas-kl1, thank you for your contribution! |
Can you link related issues that caused this PR and fix? |
There is no related issues link. |
Previous PR: #20228
The following plugin is used to clean the "block_html" and "collections" cache types by tags.
This plugin is not really used in the native Magento app, so I guess no one didn't really had issue with it (unless for eav resource models).
The
\Zend_Cache::CLEANING_MODE_MATCHING_TAG
is too restrictive as all entity tags must match with the stored data tags.Description (*)
Contribution checklist (*)