Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inline elements for inline links #1988

Merged
merged 3 commits into from
Sep 19, 2016

Conversation

chicgeek
Copy link
Contributor

The widgets for inserting product/category links into CMS blocks have a block or inline option. The inline version should use inline span elements instead of div elements.

This matches what is used for the category link inline template:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Catalog/view/frontend/templates/category/widget/link/link_inline.phtml

Use inline `span` elements instead of divs for inline link templates.
Use inline `span` elements.
@okorshenko okorshenko added the MX label Sep 30, 2015
@magento-cicd2
Copy link
Contributor

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments below.

@chicgeek
Copy link
Contributor Author

This PR now has a massive merge commit to resync because it's been open for so long. Ping me if you would prefer a rebase.

@chicgeek
Copy link
Contributor Author

@kandy What's the timeline on minor non-impactful changes such as this? There are many PRs with as minor or non-code changes that could possibly be fast tracked. Changes such as fixing typos in code comments.

Is this something I could help with?

@KrystynaKabannyk
Copy link

KrystynaKabannyk commented Apr 21, 2016

hello @chicgeek, thanks so much for your pull request, the proposed changes look good to us, and we plan to merge it in one of the nearest releases. However, we would highly appreciate if you update the code and cover it by automated tests (the checks circle has to be green), so we could merge it earlier.

@blongden
Copy link

Test is failing because of some unrelated reason Magento\MemoryUsageTest::testAppReinitializationNoMemoryLeak

@chicgeek
Copy link
Contributor Author

Hi @KrystynaKabannyk. The test fails for an unrelated reason, as Ben mentions above.

I really don't see a useful way to write an automated test the change I made. I assume this is a bucket response to PRs with failing builds?

@vkorotun vkorotun added the bugfix label Aug 5, 2016
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept labels Sep 14, 2016
@vkorotun
Copy link
Contributor

Internal ticket: MAGETWO-58371

@mmansoor-magento mmansoor-magento merged commit 684dd67 into magento:develop Sep 19, 2016
@ihor-sviziev
Copy link
Contributor

Looks like code was merged in 2842e92

@Ctucker9233
Copy link

@vkorotun @mmansoorebay Will MAGETWO-58371 be included in 2.1.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bugfix Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.