-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use inline elements for inline links #1988
Conversation
Use inline `span` elements instead of divs for inline link templates.
Use inline `span` elements.
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
This PR now has a massive merge commit to resync because it's been open for so long. Ping me if you would prefer a rebase. |
@kandy What's the timeline on minor non-impactful changes such as this? There are many PRs with as minor or non-code changes that could possibly be fast tracked. Changes such as fixing typos in code comments. Is this something I could help with? |
hello @chicgeek, thanks so much for your pull request, the proposed changes look good to us, and we plan to merge it in one of the nearest releases. However, we would highly appreciate if you update the code and cover it by automated tests (the checks circle has to be green), so we could merge it earlier. |
Test is failing because of some unrelated reason |
Hi @KrystynaKabannyk. The test fails for an unrelated reason, as Ben mentions above. I really don't see a useful way to write an automated test the change I made. I assume this is a bucket response to PRs with failing builds? |
Internal ticket: MAGETWO-58371 |
Looks like code was merged in 2842e92 |
@vkorotun @mmansoorebay Will MAGETWO-58371 be included in 2.1.3? |
The widgets for inserting product/category links into CMS blocks have a block or inline option. The inline version should use inline
span
elements instead ofdiv
elements.This matches what is used for the category link inline template:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Catalog/view/frontend/templates/category/widget/link/link_inline.phtml