Skip to content

Conversation

@eduard13
Copy link
Contributor

Description

This PR adds the integration tests for checking the not allowance to add a new product review by:

  • a guest when allow_guest is disabled
  • a guest when allow_guest is enabled and required fields aren't filled in

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 12, 2018
@eduard13 eduard13 requested a review from rogyar December 12, 2018 20:26
@eduard13 eduard13 assigned eduard13 and rogyar and unassigned eduard13 Dec 12, 2018
@rogyar
Copy link
Contributor

rogyar commented Dec 13, 2018

Hi @eduard13. Thank you for your review. Please, consider reviewing the minor recommendations provided in the review.
Also, it would be very nice to have an additional case where allow_guest is enabled.

@eduard13
Copy link
Contributor Author

eduard13 commented Dec 13, 2018

Hi @rogyar, actually I was trying to test those cases when a guest can't add new product reviews, and there is already a method (testAttemptForGuestToAddReviewsWithIncompleteData) when allow_guest is enabled, but the required fields weren't filled in.
I will try to change the purpose of the test, by adding one more case for successfully adding a review by guest.
Thank you.

@eduard13
Copy link
Contributor Author

@rogyar a new case for successfully adding a review by guest was added.
Please review the changes.
Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3702 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants