Skip to content

[Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API]#19611

Closed
ghost wants to merge 3 commits into2.2-developfrom
unknown repository
Closed

[Backport] Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero [REST API]#19611
ghost wants to merge 3 commits into2.2-developfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 7, 2018

Original Pull Request

#19451

Description

Fix: Attribute Option with zero at the beginning does not work if there is already option with the same number without the zero

Fixed Issues

  1. Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)) #19436: Attribute Option with zero at the bigining does not work if there is already option with the same number without the zero (REST API)

Manual testing scenarios

  1. Create an attribute (select or multiselect) from the backend (example: attribute_code = brand_number)
  2. add new Option to this attribute from the backend (12345)
  3. Add new Option to this attribute by the REST API (endpoint : /V1/products/attributes/brand_number/options), json = {"option":{"label":"012345"}}
  4. expected result to have two options (12345 and 012345).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 8 committers have signed the CLA.

✅ gelanivishal
✅ magento-engcom-team
✅ sidolov
❌ zakdma
❌ serhii-balko
❌ nikita-shcherbatykh
❌ dimonovp
❌ Dmytro Horytskyi


Dmytro Horytskyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: AdminNotification Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Dec 7, 2018
@ghost ghost changed the base branch from 2.3-develop to 2.2-develop December 7, 2018 10:12
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 7, 2018

closed due to extra commits

@ghost ghost closed this Dec 7, 2018
@ghost ghost deleted the 2-2-Attribute-Option-with-zero-at-the-bigining-does-not-work branch December 7, 2018 10:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: AdminNotification Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants