Skip to content

added config for wishlist sidebar in config #19554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Dec 9, 2018
Merged

added config for wishlist sidebar in config #19554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3539586
added config for wishlist sidebar in config
torhoehn Dec 4, 2018
8d1251c
added internationalization
torhoehn Dec 4, 2018
1061f87
Update app/code/Magento/Wishlist/etc/adminhtml/system.xml
sivaschenko Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/code/Magento/Wishlist/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<label>Enabled</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
<field id="show_in_sidebar" translate="label" type="select" sortOrder="5" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Show in Sidebar</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
</field>
</group>
<group id="wishlist_link" translate="label" sortOrder="3" showInDefault="1" showInWebsite="1" showInStore="0">
<label>My Wish List Link</label>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Wishlist/etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<wishlist>
<general>
<active>1</active>
<show_in_sidebar>1</show_in_sidebar>
</general>
<email>
<email_identity>general</email_identity>
Expand Down
3 changes: 2 additions & 1 deletion app/code/Magento/Wishlist/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,5 @@ Action,Action
Configure,Configure
Delete,Delete
"Product Details and Comment","Product Details and Comment"
"You must login or register to add items to your wishlist.","You must login or register to add items to your wishlist."
"You must login or register to add items to your wishlist.","You must login or register to add items to your wishlist."
"Show in Sidebar","Show in Sidebar"
2 changes: 1 addition & 1 deletion app/code/Magento/Wishlist/view/frontend/layout/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</block>
</referenceBlock>
<referenceContainer name="sidebar.additional">
<block class="Magento\Wishlist\Block\Customer\Sidebar" name="wishlist_sidebar" as="wishlist" template="Magento_Wishlist::sidebar.phtml"/>
<block class="Magento\Wishlist\Block\Customer\Sidebar" name="wishlist_sidebar" as="wishlist" template="Magento_Wishlist::sidebar.phtml" ifconfig="wishlist/general/show_in_sidebar"/>
</referenceContainer>
</body>
</page>