Skip to content

Log jobCode when writing to log with no callback for easier debug #19541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Dec 9, 2018
Merged

Log jobCode when writing to log with no callback for easier debug #19541

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
488441f
Log jobCode when writing to log with no callback for easier debug
cscd98 Dec 4, 2018
d4717ae
Add missing sprintf statement
cscd98 Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ protected function _runJob($scheduledTime, $currentTime, $jobConfig, $schedule,

if (!isset($jobConfig['instance'], $jobConfig['method'])) {
$schedule->setStatus(Schedule::STATUS_ERROR);
throw new \Exception('No callbacks found');
throw new \Exception('No callbacks found for cron job %s', $jobCode);

@orlangur orlangur Dec 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you miss sprintf call here? Better use "This is $string".

Also, please provide more detailed steps to reproduce.

@cscd98 cscd98 Dec 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur good spot :)

If you have a database converted from M1 to M2, certain crons may no longer exist.

For example: crontab/jobs/catalog_price_rule_update/schedule/cron_expr

However, there is no call back for this cron expr.

So magento error logs just contain 'No callbacks found' for several items. With this code, it now shows which cron job can be removed.

@cscd98 cscd98 Dec 4, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur re pushed with sprintf added

}
$model = $this->_objectManager->create($jobConfig['instance']);
$callback = [$model, $jobConfig['method']];
Expand Down