Skip to content

Fixed issue 19509 - Catalog bundle product Bundle Items inconsistent box border#19510

Merged
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
abrarpathan19:fixed-issue-19509
Dec 9, 2018
Merged

Fixed issue 19509 - Catalog bundle product Bundle Items inconsistent box border#19510
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
abrarpathan19:fixed-issue-19509

Conversation

@abrarpathan19
Copy link
Copy Markdown
Contributor

Description (*)

Catalog bundle product Bundle Items inconsistent box border

Fixed Issues (if relevant)

  1. Catalog bundle product Bundle Items inconsistent box border  #19509: Catalog bundle product Bundle Items inconsistent box border

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 1, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

&.collapsible-block-wrapper-last {
border-bottom: 0;
}
.admin__dynamic-rows.admin__control-collapsible{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.admin__dynamic-rows.admin__control-collapsible{
.admin__dynamic-rows.admin__control-collapsible {

@sivaschenko sivaschenko self-assigned this Dec 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 2, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3605 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @abrarpathan19. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants