Skip to content

Conversation

@SyntaxKay
Copy link
Contributor

@SyntaxKay SyntaxKay commented Dec 1, 2018

Description (*)

Frontend Minicart dropdown alignment issue

Fixed Issues (if relevant)

1.#19507: Frontend Minicart dropdown alignment issue

Manual testing scenarios (*)

1.Check Minicart dropdown alignment

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Dec 1, 2018
@SyntaxKay SyntaxKay requested a review from Karlasa December 1, 2018 12:52
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Karlasa
Copy link
Contributor

Karlasa commented Dec 1, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-19508.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@SyntaxKay
Copy link
Contributor Author

Hi @Karlasa
I have updated CSS code Please review it.

Copy link
Contributor

@Karlasa Karlasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for nitpicking, you did great job. Well done :)

@SyntaxKay SyntaxKay added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Dec 20, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3721 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop December 22, 2018 00:35
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop December 22, 2018 00:35
@magento-engcom-team magento-engcom-team merged commit e864a0c into magento:2.3-develop Dec 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants