Skip to content

[Backport] Adding integration tests for wrong captcha#19427

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
eduard13:2.2-develop-19183-bp
Nov 29, 2018
Merged

[Backport] Adding integration tests for wrong captcha#19427
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
eduard13:2.2-develop-19183-bp

Conversation

@eduard13
Copy link
Contributor

Original Pull Request

#19183

Description

This PR adds the integration tests for checking the wrong captcha for the forms on the following pages:

  • customer/account/login/
  • customer/account/forgotpassword/
  • customer/account/create/

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@eduard13 eduard13 requested a review from rogyar November 28, 2018 10:45
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Nov 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3580 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Ctucker9233
Copy link

@magento-engcom-team This was not included in 2.2.8. Will it be in 2.2.9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants