fix: remove old code in tabs, always set tabindex to 0 when tabs are …#19326
Merged
magento-engcom-team merged 1 commit into2.3-developfrom Nov 22, 2018
unknown repository
Merged
fix: remove old code in tabs, always set tabindex to 0 when tabs are …#19326magento-engcom-team merged 1 commit into2.3-developfrom unknown repository
magento-engcom-team merged 1 commit into2.3-developfrom
unknown repository
Conversation
Contributor
|
Hi @DanielRuf. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sivaschenko
approved these changes
Nov 22, 2018
Contributor
|
Hi @sivaschenko, thank you for the review. |
Contributor
|
Hi @DanielRuf. Thank you for your contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…initialized
Description (*)
There seems to be old code which is duplicate. We always want to set the tabindex to
0so it can be removed.Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)