Skip to content

Reducing space when there is no message on the page#19295

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
rodrigoobiassi:space_when_there_is_no_message
Dec 9, 2018
Merged

Reducing space when there is no message on the page#19295
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
rodrigoobiassi:space_when_there_is_no_message

Conversation

@rodrigoobiassi
Copy link
Copy Markdown
Member

  • There is an unnecessary fixed size in the message area that leaves the title very separate from the top

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rodrigoobiassi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 21, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3506 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@rodrigoobiassi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@rodrigoobiassi
Copy link
Copy Markdown
Member Author

Thanks guys, I already accepted Community Contributors team invitation.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rodrigoobiassi. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants