Skip to content

issue #19205 fixed for 2.3-develop#19261

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mahesh-rajawat:2.3-bundle-cart-fix
Dec 6, 2018
Merged

issue #19205 fixed for 2.3-develop#19261
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
mahesh-rajawat:2.3-bundle-cart-fix

Conversation

@mahesh-rajawat
Copy link
Copy Markdown
Member

@mahesh-rajawat mahesh-rajawat commented Nov 18, 2018

Original Pull Request

#19260

Description (*)

Fixed Issues (if relevant)

  1. Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart #19205
  2. ...

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Copy link
Copy Markdown
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, this was broken in 74e9299#diff-378766b0b55da1208705729c21a0f7b3

Thanks @maheshWebkul721!

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3487 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants