Skip to content

magento/magento2#18939: [Forwardport] fixed js translation. #19174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Nov 16, 2018
Merged

magento/magento2#18939: [Forwardport] fixed js translation. #19174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/code/Magento/Tax/i18n/en_US.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,4 @@ Rate,Rate
"Your credit card will be charged for","Your credit card will be charged for"
"An error occurred while loading tax rates.","An error occurred while loading tax rates."
"You will be charged for","You will be charged for"
"Not yet calculated", "Not yet calculated"
7 changes: 4 additions & 3 deletions app/code/Magento/Tax/view/frontend/web/js/view/checkout/summary/tax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ define([
'ko',
'Magento_Checkout/js/view/summary/abstract-total',
'Magento_Checkout/js/model/quote',
'Magento_Checkout/js/model/totals'
], function (ko, Component, quote, totals) {
'Magento_Checkout/js/model/totals',
'mage/translate'
], function (ko, Component, quote, totals, $t) {
'use strict';

var isTaxDisplayedInGrandTotal = window.checkoutConfig.includeTaxInGrandTotal,
Expand All @@ -22,7 +23,7 @@ define([
return Component.extend({
defaults: {
isTaxDisplayedInGrandTotal: isTaxDisplayedInGrandTotal,
notCalculatedMessage: 'Not yet calculated',
notCalculatedMessage: $t('Not yet calculated'),
template: 'Magento_Tax/checkout/summary/tax'
},
totals: quote.getTotals(),
Expand Down