Skip to content

Fixed subscribe to newsletter if you already have an account issue #8952 -2.3 develop #19164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 3 commits into from
Dec 10, 2018
Merged

Fixed subscribe to newsletter if you already have an account issue #8952 -2.3 develop #19164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
78b694f
Merge pull request #3 from magento/2.3-develop
ravi-chandra3197 Nov 12, 2018
ebfffe4
Fixed subscribe to newsletter if you already have an account issue #8952
ravi-chandra3197 Nov 12, 2018
b8941a8
Merge branch '2.3-develop' into patch-8952-2.3-develop
ravi-chandra3197 Dec 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/code/Magento/Newsletter/Controller/Subscriber/NewAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ public function __construct(
protected function validateEmailAvailable($email)
{
$websiteId = $this->_storeManager->getStore()->getWebsiteId();
if ($this->_customerSession->getCustomerDataObject()->getEmail() !== $email
&& !$this->customerAccountManagement->isEmailAvailable($email, $websiteId)
if ($this->_customerSession->isLoggedIn()
&& ($this->_customerSession->getCustomerDataObject()->getEmail() !== $email
&& !$this->customerAccountManagement->isEmailAvailable($email, $websiteId))
) {
throw new LocalizedException(
__('This email address is already assigned to another user.')
Expand Down
2 changes: 1 addition & 1 deletion dev/tests/integration/testsuite/Magento/Newsletter/Controller/SubscriberTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function testNewActionUsedEmail()
$this->dispatch('newsletter/subscriber/new');

$this->assertSessionMessages($this->equalTo([
'This email address is already assigned to another user.',
'Thank you for your subscription.',
]));
$this->assertRedirect($this->anything());
}
Expand Down