Skip to content

19082-Fatal-error-Uncaught-Error-Cannot-call-abstract-method-Magento-…#19155

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
agorbulin:19082-Fatal-error-Uncaught-Error-Cannot-call-abstract-method-Magento-Framework-App-ActionInterface-execute
Nov 22, 2018
Merged

19082-Fatal-error-Uncaught-Error-Cannot-call-abstract-method-Magento-…#19155
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
agorbulin:19082-Fatal-error-Uncaught-Error-Cannot-call-abstract-method-Magento-Framework-App-ActionInterface-execute

Conversation

@agorbulin
Copy link
Copy Markdown

…Framework-App-ActionInterface-execute

add execute method to prevent fatal error when go to catalog/product/compare/

Description (#19082)

Fatal error when go to path catalog/product/compare/

Fixed Issues (#19082)

  1. Fatal error: Uncaught Error: Cannot call abstract method Magento\Framework\App\ActionInterface::execute() #19082: Fatal error: Uncaught Error: Cannot call abstract method Magento\Framework\App\ActionInterface::execute()

Manual testing scenarios (*)

  1. Go to by path catalog/product/compare/
  2. Expected results:
    redirect to catalog/product_compare/ instead of 500 error

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…Framework-App-ActionInterface-execute

add method to prevent fatal error when go to catalog/product/compare/
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Catalog labels Nov 10, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 12, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3435 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rodrigowebjump, thank you for the review.
ENGCOM-3435 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@agorbulin thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit ae61da5 into magento:2.3-develop Nov 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 22, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Award: bug fix Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants