Skip to content

Add availability to leave empty config for events.xml #19145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Dec 10, 2018
Merged

Add availability to leave empty config for events.xml #19145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04bc0fb
Add availability to leave empty config for events.xml
lisovyievhenii Nov 10, 2018
551a268
Fix unit test of Framework/Event module
lisovyievhenii Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/internal/Magento/Framework/Event/Test/Unit/Config/_files/invalidEventsXmlArray.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
* See COPYING.txt for license details.
*/
return [
'without_event_handle' => [
'<?xml version="1.0"?><config></config>',
["Element 'config': Missing child element(s). Expected is ( event ).\nLine: 1\n"],
],
'event_without_required_name_attribute' => [
'<?xml version="1.0"?><config><event name="some_name"></event></config>',
["Element 'event': Missing child element(s). Expected is ( observer ).\nLine: 1\n"],
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Event/etc/events.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<xs:element name="config">
<xs:complexType>
<xs:sequence>
<xs:element name="event" type="eventDeclaration" minOccurs="1" maxOccurs="unbounded">
<xs:element name="event" type="eventDeclaration" minOccurs="0" maxOccurs="unbounded">
<xs:unique name="uniqueObserverName">
<xs:annotation>
<xs:documentation>
Expand Down