missing use statement in layout generator#19009
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom Nov 22, 2018
Merged
Conversation
Contributor
Contributor
|
Hi @adeptofvoltron. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Nov 2, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
Contributor
|
@adeptofvoltron thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
Author
Contributor
|
Hi @adeptofvoltron. Thank you for your contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Simple change. LocalizedException was used in class \Magento\Framework\View\Layout\Generator\Block, but it were missing in use section. It were not causing any fatal errors because of the way how it was used in method \Magento\Framework\View\Layout\Generator\Block::handleRenderException:
Fixed Issues (if relevant)
Manual testing scenarios (*)
1.force any block to throw LocalizedException during generation, and check error message in logs. It ought to be message from the \Magento\Framework\Exception\LocalizedException::getLogMessage method
Contribution checklist (*)