Skip to content

Conversation

@ktpl-prakash
Copy link
Contributor

@ktpl-prakash ktpl-prakash commented Oct 31, 2018

Original Pull Request

#17978

Description

Fixed Last Logged In date when we authenticate a customer via REST API.

Fixed Issues (if relevant)

#17488: Authenticating a customer via REST API does not update the last logged in data #17488

Manual testing scenarios

  1. Create a new customer account
  2. Login with that customer using the default Magento frontend
  3. View the customer in the Magento admin area, and note that the Last Logged In value has been updated
  4. Request a customer token via this API endpoint: /rest/V1/integration/customer/token

http://{{base_url}}/rest/V1/integration/customer/token/?username=[email protected]&password=examplel@123

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @prakashpatel07. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

… does not update the last logged in data magento#18973

- Fixed docblocks
@magento-engcom-team
Copy link
Contributor

Hi @prakashpatel07. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

magento-engcom-team pushed a commit that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants