LESS code clean up

[Karlasa]

Description (*)

LESS code clean up to follow coding standards

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. ...
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[DanielRuf]

Removing .lib-css is not a good idea.

[DanielRuf]

https://magento.stackexchange.com/questions/94185/what-is-the-purpose-of-the-less-lib-css-mixin

Which removes duplicate and overwritten rules.

[DanielRuf]

Also Update filename is not a clear commit message. Please rebase and reword them.

[Karlasa]

@DanielRuf Fixed some lib-css but for @indent/@font-weight it does not make sense having it as almost everywhere else it's called without it.

[DanielRuf]

@DanielRuf Fixed some lib-css but for @indent/@font-weight it does not make sense having it as almost everywhere else it's called without it.

Why not? It is especially meant for variables and to merge rules and overwrite them without adding strikethrough rules on the browser side.

[Karlasa]

What do you mean by merge rules?

Why not?

if you have it without .lib-css() in 90% then i would never change it to false as i would end up cleaning up that 10% code but with 90% of incorrect code eg. padding: false/font-weight: false
So it would make sense to clean it up. Also not having padding in or font-weight in site is quite strange case. i get .lib-css() if it's more specific variable.
ex:
@minicart-padding: @indent__s;
.lib-css(padding, @minicart-padding);
would make sense for me as there are cases where you would like to disable it but not with that general variables

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-3342 has been created to process this Pull Request

[Karlasa]

@VladimirZaets what is needed to be updated?

[VladimirZaets]

Hi @Karlasa, I add "Need update" label because Daniel had some question according to fix. I looked the fix, and I think it is ok. Thanks for collaboration.

[magento-engcom-team]

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.