small performance improvement on product listing#18773
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Nov 22, 2018
Merged
small performance improvement on product listing#18773magento-engcom-team merged 1 commit intomagento:2.3-developfrom
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
Conversation
Get rid of unnecessary reviews queries on product listing: "select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)" This query was executed for each product on listing which didn't have a review summary(@see: Magento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtml)
Contributor
Contributor
|
Hi @godvsdeity. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
miguelbalparda
approved these changes
Nov 12, 2018
Contributor
|
Hi @miguelbalparda, thank you for the review. |
Contributor
|
@godvsdeity thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Contributor
|
Hi @godvsdeity. Thank you for your contribution. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Nov 22, 2018
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Get rid of unnecessary reviews queries on product listing:
"select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)"
This query was executed for each product on listing which didn't have a review summary(@see:
Magento\Review\Model\Review::appendSummaryandMagento\Review\Block\Product\ReviewRenderer::getReviewsSummaryHtml)Manual testing scenarios (*)
E.g.: if on your product listing page you are listing 20 products, and 3 products have reviews, you will see 17 x "select review_entity_summary.* from review_entity_summary where (review_entity_summary.entity_pk_value = ?) and (store_id = ?)"
Contribution checklist (*)