Skip to content

Collect totals in placeOrder when no paymentMethod provided#18768

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
pmclain:issue/16050
Dec 10, 2018
Merged

Collect totals in placeOrder when no paymentMethod provided#18768
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
pmclain:issue/16050

Conversation

@pmclain
Copy link
Copy Markdown
Contributor

@pmclain pmclain commented Oct 23, 2018

Description (*)

Quote item values such as base_original_price are only populated during total
collection. Currently in QuoteManagement::placeOrder if $paymentMethod is
passed Payment::importData collects the quote totals to populate these values.

Payment methods like Auth.net DirectPost do pass a value for $paymentMethod
during order placement which causes order items to be converted with zero
values for the original_price attributes.

Fixed Issues (if relevant)

  1. Authorize.net  #16050 Authorize.net

Manual testing scenarios (*)

  1. Enable Authorize.net Direct Post payment method
  2. Add product to cart
  3. Place order using Authorize.net Direct Post payment method
  4. Open order detail view in admin panel
  5. Order item original price should not be zero

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Quote item values such as `base_original_price` are only populated during total
collection. Currently in `QuoteManagement::placeOrder` if `$paymentMethod` is
passed `Payment::importData` collects the quote totals to populate these values.

Payment methods like Auth.net DirectPost do pass a value for `$paymentMethod`
during order placement which causes order items to be converted with zero
values for the `original_price` attributes.

Fixes magento#16050
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka slavvka self-assigned this Oct 23, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 23, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3257 has been created to process this Pull Request

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18768//admin
Login: admin Password: 123123q

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team indexer:reindex

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18768-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18768-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18768//admin
Login: admin Password: 123123q

@TomashKhamlai
Copy link
Copy Markdown
Contributor

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: https://pr-18768.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team merged commit 389a16b into magento:2.3-develop Dec 10, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @pmclain. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants