fixed issue #18458 : Alert widget gets close when click anywhere on screen #18576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
|
Hi @ShubhamSharma967. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Author
|
I have fixed Travis CI issue in commit - 2022b0a |
Author
|
#SQUASHTOBERFEST |
Contributor
|
Hi @Shubham-Webkul , please, sign CLA, otherwise, we can't process your pull request |
magento-engcom-team
added a commit
that referenced
this pull request
Oct 29, 2018
Accepted Public Pull Requests: - #18917: Fixed-Global-search icon misaligned (by @speedy008) - #18591: [Backport] Fix SKU limit in import new products (by @ravi-chandra3197) - #18862: [Backport] Adding trimming sku value function to sku backend model. (by @gelanivishal) - #18865: fixed issue #18458 : Alert widget gets close when click anywhere on screen #18576 (by @Shubham-Webkul) - #18886: [Backport] fixed Translation issue send-friend in send.phtml (by @rahulwebkul) Fixed GitHub Issues: - #18913: Global-search icon misaligned (reported by @speedy008) has been fixed in #18917 by @speedy008 in 2.2-develop branch Related commits: 1. 3cbc255 - #17865: import new products via csv: products are created with empty value when strings are too long (reported by @LouNik1984) has been fixed in #18591 by @ravi-chandra3197 in 2.2-develop branch Related commits: 1. e59dee0 2. a10f074 3. ad68105 - #12300: SKU values are not trimmed with the space. (reported by @ShaileshChauhan92) has been fixed in #18862 by @gelanivishal in 2.2-develop branch Related commits: 1. 109a27e - #16572: Trim whitespace on SKU when saving product (reported by @Zyles) has been fixed in #18862 by @gelanivishal in 2.2-develop branch Related commits: 1. 109a27e - #18458: Magento version 2.2.6 Alert widget gets close when click anywhere on screen (reported by @asgarh) has been fixed in #18865 by @Shubham-Webkul in 2.2-develop branch Related commits: 1. f59bc17 2. 06b243f 3. c3bc361 4. 26a9520 5. 87167e7 6. c6586ab 7. d40a26c 8. 84c7391 9. e1483f6 10. 3b2e4e4 11. 7dc2d1b - #18779: Translation issue send-friend in sendphtml (reported by @Franzld) has been fixed in #18886 by @rahulwebkul in 2.2-develop branch Related commits: 1. 443e681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue of Alert widget gets close when click anywhere on screen .
Description
In older version of magento 2.2.6 when we click delete button of minicart then alert widget display for confirm to delete item from cart.This popup was only close when click on "cancel", "ok" & "close" button.But earlier version of magento 2.2.6 it is closing click anywhere on screen.In this PR i have fixed this issue.
Fixed Issues
#18458: Magento version 2.2.6 Alert widget gets close when click anywhere on screen #18458
Manual testing scenarios
1 - Add product into cart.
2- Click on cart logo and delete item from cart.
3 - Now popup will open for confirm.
4 - Click anywhere on screen.Now popup will not close.