Skip to content

[Forwardport] Added checks to see if the payment is available#18521

Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15683
Dec 10, 2018
Merged

[Forwardport] Added checks to see if the payment is available#18521
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
gelanivishal:2.3-develop-PR-port-15683

Conversation

@gelanivishal
Copy link
Copy Markdown
Contributor

@gelanivishal gelanivishal commented Oct 11, 2018

Original Pull Request

#15683

Fix an error while submitting an order without payment method.

Description

When submitting an order using the rest api without an payment, you would get an exception/error report due to the fact there was not payment method.

Fixed Issues (if relevant)

  1. REST API create order POST /V1/orders #15652: REST API create order POST /V1/orders

Manual testing scenarios

  1. Send an POST request to the rest/V1/orders endpoint containing the following:
    { "entity": { "base_grand_total" : 100, "customer_email" : "user@domain.tld", "grand_total" : 100, "items" : [ { "sku" : "TESTSEB" } ] } }

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Copy Markdown
Contributor

sidolov commented Oct 11, 2018

Hi @gelanivishal , please, add following commit to this port: 7bc5df7
Thank you!

@gelanivishal
Copy link
Copy Markdown
Contributor Author

@sidolov Added.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 11, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3156 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants