Skip to content

Added missing throw tag for exception to docblock of construct #18506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 1 commit into from
Oct 12, 2018
Merged

Added missing throw tag for exception to docblock of construct #18506

magento-engcom-team merged 1 commit into from
Oct 12, 2018

Conversation

@peterjaap
Copy link
Contributor

@peterjaap peterjaap commented Oct 10, 2018

Description

Added missing throw tag for exception to docblock of construct

Fixed Issues (if relevant)

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 10, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rogyar rogyar self-assigned this Oct 10, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 10, 2018
@magento-engcom-team magento-engcom-team merged commit 028dca2 into magento:2.3-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
ENGCOM-3150: Added missing throw tag for exception to docblock of con…
6f4c0dc 
…struct #18506
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 12, 2018

Hi @peterjaap. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 12, 2018

Hi @peterjaap. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@peterjaap peterjaap deleted the update-doc-block-with-throw-tag branch October 12, 2018 10:52
@dmytro-ch dmytro-ch mentioned this pull request Oct 13, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rogyar rogyar

@sidolov sidolov

Labels

Cleanup Component: OfflineShipping Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@peterjaap @magento-cicd2 @magento-engcom-team @rogyar @sidolov