[Backport] Improve code quality subscriber new action#18433
Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom Oct 8, 2018
Merged
Conversation
+ Refactor `else` block for returning success message to private function + Use import statements for classes + Because imports are being used an `if` statement can be written on one line + Use `addExceptionMessage` and `addSuccessMessage` instead of their deprecated counterparts + Include with DI the `Magento\Framework\Validator\EmailAddress` class which can be used to validate the email address. Therefore the static function call to the `is` method on the `Zend_Validate` class is not needed anymore.
magento-engcom-team
added
Partner: Experius
partners-contribution
magento-engcom-team
pushed a commit
that referenced
this pull request
Oct 8, 2018
Contributor
|
Hi @lewisvoncken. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
1 similar comment
Contributor
|
Hi @lewisvoncken. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17232
elseblock for returning success message to private function@throwntag and add missing@throwntagifstatement can be written on one lineaddExceptionMessageandaddSuccessMessageinstead of their deprecated counterpartsContribution checklist