-
Notifications
You must be signed in to change notification settings - Fork 9.4k
throw exception InvalidArgumentException during validate scheme #18416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw exception InvalidArgumentException during validate scheme #18416
Conversation
lib/internal/Magento/Framework/Test/Unit/Communication/Config/ValidatorTest.php
Show resolved
Hide resolved
lib/internal/Magento/Framework/Test/Unit/Communication/Config/ValidatorTest.php
Show resolved
Hide resolved
lib/internal/Magento/Framework/Test/Unit/Communication/Config/ValidatorTest.php
Show resolved
Hide resolved
| } | ||
|
|
||
| /** | ||
| * @expectedException \LogicException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please validate exception message
| * 'validatePassword' => 'boolean' | ||
| * ] | ||
| * </pre> | ||
| * @throws \InvalidArgumentException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add description if which exception will be thrown
| * | ||
| * @param string $interfaceName | ||
| * @return array | ||
| * @throws \ReflectionException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add description if which exception will be thrown
| * @param string $typeName | ||
| * @return $this | ||
| * @throws \Exception In case when type is invalid | ||
| * @throws \InvalidArgumentException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add description if which exception will be thrown
…asses. Implemented validation of exception message in unit test
|
Hi @ArtsiomBruneuski. Thank you for your contribution. |
Description
Fixed Issues (if relevant)
Manual testing scenarios
A schema class:
class Dummy {
private $foo;
}
Run validation for communication configuration. It can be done either automatically if you're using Magento EE, or can be done manually by calling into Magento\Framework\Communication\Config->getTopic("foo_topic")Communication configuration (communication.xml):
Contribution checklist