Skip to content

Conversation

@ArtsiomBruneuski
Copy link
Contributor

@ArtsiomBruneuski ArtsiomBruneuski commented Oct 6, 2018

Description

Fixed Issues (if relevant)

  1. Communication's component validator does not propagate exceptions, obscuring the cause of the error #14555

Manual testing scenarios

A schema class:
class Dummy {
private $foo;

public function getFoo() { return $this->foo; }
public function setFoo($foo) { $this->foo = $foo; }

}
Communication configuration (communication.xml):

Run validation for communication configuration. It can be done either automatically if you're using Magento EE, or can be done manually by calling into Magento\Framework\Communication\Config->getTopic("foo_topic")

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 6, 2018

CLA assistant check
All committers have signed the CLA.

}

/**
* @expectedException \LogicException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please validate exception message

* 'validatePassword' => 'boolean'
* ]
* </pre>
* @throws \InvalidArgumentException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description if which exception will be thrown

*
* @param string $interfaceName
* @return array
* @throws \ReflectionException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description if which exception will be thrown

* @param string $typeName
* @return $this
* @throws \Exception In case when type is invalid
* @throws \InvalidArgumentException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add description if which exception will be thrown

@magento-engcom-team
Copy link
Contributor

Hi @ArtsiomBruneuski. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants