Skip to content

Support of error pages behind a load balancer that serves HTTPS #18333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 4 commits into from
Oct 25, 2018
Merged

Support of error pages behind a load balancer that serves HTTPS #18333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e120448
Support of error pages behind a load balancer that serves HTTPS but a…
stkams Oct 1, 2018
b1b3928
Support of error pages behind a load balancer that serves HTTPS but a…
stkams Oct 3, 2018
53452fb
Support of error pages behind a load balancer that serves HTTPS but a…
stkams Oct 3, 2018
320c0aa
Support of error pages behind a load balancer that serves HTTPS
ihor-sviziev Oct 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pub/errors/processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ public function getHostUrl()
$host = 'localhost';
}

$isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] != 'off');
// HTTP_X_FORWARDED_PROTO to check whether a webserver using HTTP is behind a load balancer serving HTTPS
Copy link
Contributor

@ihor-sviziev ihor-sviziev Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think comment is not needed there, it's pretty obvious for what this header is needed.

$isSecure = (!empty($_SERVER['HTTPS'])) && ($_SERVER['HTTPS'] != 'off') || $_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https';
Copy link
Contributor

@ihor-sviziev ihor-sviziev Oct 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add checking that $_SERVER['HTTP_X_FORWARDED_PROTO'] exists, otherwise we'll have notice there

$url = ($isSecure ? 'https://' : 'http://') . $host;

if (!empty($_SERVER['SERVER_PORT']) && !in_array($_SERVER['SERVER_PORT'], [80, 443])
Expand Down