[2.3] changed intval($val) to (int) $val, since (int) $val is faster.#17946
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Sep 11, 2018
Merged
Conversation
Contributor
|
Hi @TBlindaruk. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
TBlindaruk
force-pushed
the
changed_intval_to_int_casting
branch
2 times, most recently
from
4b73c06 to
0372245
Compare
TBlindaruk
force-pushed
the
changed_intval_to_int_casting
branch
from
0372245 to
de08a7b
Compare
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 11, 2018
Contributor
|
Hi @TBlindaruk. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2.3] changed intval($val) to (int) $val, since
(int) $valis faster.