[Forwardport] Remove leading Countrycode from EU-VAT-Numbers#17921
Merged
magento-engcom-team merged 6 commits intomagento:2.3-developfrom Sep 11, 2018
mage2pratik:2.3-develop-PR-port-17385
Merged
[Forwardport] Remove leading Countrycode from EU-VAT-Numbers#17921magento-engcom-team merged 6 commits intomagento:2.3-developfrom mage2pratik:2.3-develop-PR-port-17385
magento-engcom-team merged 6 commits intomagento:2.3-developfrom
mage2pratik:2.3-develop-PR-port-17385
Conversation
EU-VAT-Numbers has always leading Countrycodes. To validate VAT-Number we have to remove it before sending the request. After we've checked if country is in eu we will remove the Countrycode and send the request.
Moved variable $requestParams[] out of ternary operator. To do this, the new variables $vatNumberSanitized and $requesterVatNumberSanitized are introduced.
Changed one-line ternary to multiline ternary to not exceed line-size-limit of 120 Characters.
Changed newly introduced variable VatNumberSanitized to reqVatNumSanitized to meet coding standards.
Contributor
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
sidolov
approved these changes
Sep 5, 2018
Contributor
|
Hi @sidolov, thank you for the review. |
Contributor
|
Hi @mage2pratik. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17385
Description
EU-VAT-Numbers has always leading Countrycodes. To validate VAT-Number we have to remove it before sending the request.
After we've checked if country is in eu we will remove the Countrycode and send the request.
Fixed Issues (if relevant)
EU-VAT-Numbers always invalid cause of leading Countrycodes.
Manual testing scenarios
EU-VAT-Numbers looks like DEXXXXXXXXX for a german one.
Before change:
Giving DE 293 778 674 in Configuration->General->Store Information or in creating an Account will resullt in "Invalid VAT".
After change:
Giving DE 293 778 674 in Configuration->General->Store Information or in creating an Account will resullt in "VAT-Number is valid".
Contribution checklist