Skip to content

#17890: show correct text swatch values per store view#17891

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
magicaner:bugfix/fix-issue-17890
Sep 22, 2018
Merged

#17890: show correct text swatch values per store view#17891
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
magicaner:bugfix/fix-issue-17890

Conversation

@magicaner
Copy link
Contributor

Description

Show correct text swatches values per store view.

Fixed Issues (if relevant)

  1. Magento 2.2.5 Product swatches does not shows correct value for related store view #17890: Magento 2.2.5 Product swatches does not shows correct value for related store view

Manual testing scenarios

  1. Install fresh magento with default simple data
  2. Edit swatch values for size attribute.
  3. Change value for default store to XS D. And for admin store set XS A
    image
  4. Run bin/magento index:reindex to reindex all indexes
  5. Run bin/magento cache:clean block_html full_page
  6. Open product view page on frontend SKU=MH01
  7. Value of size attribute should have XS D value instead of XS A
    image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @magicaner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

@magicaner thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-2912 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @magicaner. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants