Fix for missing url_key after product import#17879
Closed
evilprophet wants to merge 1 commit intomagento:2.2-developfrom
evilprophet:fix-17023
Closed
Fix for missing url_key after product import#17879evilprophet wants to merge 1 commit intomagento:2.2-developfrom evilprophet:fix-17023
evilprophet wants to merge 1 commit intomagento:2.2-developfrom
evilprophet:fix-17023
Conversation
Contributor
|
|
Contributor
|
Hi @evilprophet. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
@evilprophet thanks a lot for your contribution. This PR #17882 (review) looks more complete as its includes functionality to validate also "name" columns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fix will protect import for overwriting url_key when this is not specified in the import file.
$this->getUrlKey($rowData);This returnsurl_keywhen this is specified in the file or create it based onname, but in the situation when these 2 fields are missing in file empty string will be returned and used to overwrite url_key for imported products.Fixed Issues (if relevant)
sku,attributeemptiesurl_keyvalue #17023>: CSV Import ofsku,attributeemptiesurl_keyvalueContribution checklist