Skip to content

Fix for missing url_key after product import#17879

Closed
evilprophet wants to merge 1 commit intomagento:2.2-developfrom
evilprophet:fix-17023
Closed

Fix for missing url_key after product import#17879
evilprophet wants to merge 1 commit intomagento:2.2-developfrom
evilprophet:fix-17023

Conversation

@evilprophet
Copy link
Copy Markdown

@evilprophet evilprophet commented Aug 31, 2018

Description

This fix will protect import for overwriting url_key when this is not specified in the import file.
$this->getUrlKey($rowData); This returns url_key when this is specified in the file or create it based on name, but in the situation when these 2 fields are missing in file empty string will be returned and used to overwrite url_key for imported products.

Fixed Issues (if relevant)

  1. CSV Import of sku,attribute empties url_key value #17023>: CSV Import of sku,attribute empties url_key value

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @evilprophet. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nuzil
Copy link
Copy Markdown
Contributor

nuzil commented Sep 3, 2018

@evilprophet thanks a lot for your contribution. This PR #17882 (review) looks more complete as its includes functionality to validate also "name" columns.

@nuzil nuzil closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants