Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying Special Price excluding tax #17791

Closed

Conversation

magently
Copy link

Description

Whenever a Special Price and a Regular Price was displayed with tax and without, the amount of the Special Price without tax was changed into one equal to the amount of Regular Price without tax.

Fixed Issues (if relevant)

  1. Old price excluding TAX is incorrectly replaced by JavaScript #11998: Old price excluding TAX is incorrectly replaced by JavaScript

Manual testing scenarios

Same as Fixed Issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Jason-Sy
Copy link
Member

Jason-Sy commented Oct 24, 2018

These changes will break the option select price update functionality for configurable products (if they have a different price based on the selected options).

Without the fix + without options:
screen shot 2018-10-24 at 14 33 18

Without the fix + Options:
screen shot 2018-10-24 at 14 33 29

With the fix + without options:
screen shot 2018-10-24 at 14 35 31
With the fix + Options:
screen shot 2018-10-24 at 14 35 38

@josefbehr
Copy link
Contributor

@magently pls have a look again

@magently
Copy link
Author

magently commented Nov 8, 2018

@Jason-Sy Thank you for reporting.
@josefbehr We will check it and give an answer.

@sidolov
Copy link
Contributor

sidolov commented Nov 22, 2018

Hi @magently , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Nov 22, 2018
@magently magently deleted the fix/displaying-special-price branch August 9, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants