Skip to content

[Backport] Changed storage.php#17776

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
MartinAarts:patch-1
Aug 28, 2018
Merged

[Backport] Changed storage.php#17776
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
MartinAarts:patch-1

Conversation

@MartinAarts
Copy link
Copy Markdown

@MartinAarts MartinAarts commented Aug 23, 2018

renamed variable on line 572 & 589, from $keepRation to $keepRatio.
As noted in issue #17587

Backport for: #17596

renamed variable on line 572 & 589, from $keepRation to $keepRatio
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @MartinAarts. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2872 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

@MartinAarts thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @MartinAarts. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants