Skip to content

[Forwardport] Misleading data-container in product list#17751

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-15350
Aug 26, 2018
Merged

[Forwardport] Misleading data-container in product list#17751
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
nmalevanec:2.3-develop-PR-port-15350

Conversation

@nmalevanec
Copy link
Copy Markdown
Contributor

Original Pull Request

#15350

Issue :- #15319

Description

  • change data-container class name based on view mode

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Aug 23, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2869 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants