Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Added template as argument to the store address renderer to allow custom formatting #17613

Merged
merged 2 commits into from
Aug 15, 2018
Merged

[Backport] Added template as argument to the store address renderer to allow custom formatting #17613

merged 2 commits into from
Aug 15, 2018

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Aug 14, 2018

Original Pull Request

#11138

Description

Fixed Issues (if relevant)

Manual testing scenarios

  1. Create an order as customer
  2. Check email
  3. On fresh Magento installation store information is missing and you should see 2 ugly meaningless comma signs in the footer of the email.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants