Skip to content

Fixed undefinded shipping method name issue #17492 #17526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 2 commits into from
Aug 14, 2018
Merged

Fixed undefinded shipping method name issue #17492 #17526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c789fb2
Fixed undefinded shipping method name issue
gelanivishal Aug 11, 2018
7aecb1f
Fixed undefinded shipping method name issue #17492
VladimirZaets Aug 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/code/Magento/Checkout/view/frontend/web/js/view/summary/shipping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,18 @@ define([
*/
getShippingMethodTitle: function () {
var shippingMethod;
var shippingMethodTitle = '';

if (!this.isCalculated()) {
return '';
}
shippingMethod = quote.shippingMethod();

return shippingMethod ? shippingMethod['carrier_title'] + ' - ' + shippingMethod['method_title'] : '';
if (typeof(shippingMethod['method_title']) != 'undefined') {
shippingMethodTitle = ' - ' + shippingMethod['method_title'];
}

return shippingMethod ? shippingMethod['carrier_title'] + shippingMethodTitle : '';
Copy link
Contributor

@krzksz krzksz Aug 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, your code will return empty string if no method_title is found. Can we make it return carrier_title in that case? Then we would have e.g. Flat Rate instead of Flat Rate - undefined or empty string which is a best solution in my opinion.

},

/**
Expand Down