Skip to content

Conversation

@maximbaibakov
Copy link

Add Australian regions to Magento Vanila Install

Description

Add Australian regions to be as a dropdown during address population

Fixed Issues (if relevant)

  1. Add Australian regions #17514: Add Australian regions

Manual testing scenarios

  1. Add product to cart
  2. Go to checkout
  3. Select Australia as shipping / billing country
  4. I see Australian regions as a dropdown

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 11, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: Balance Internet partners-contribution Pull Request is created by Magento Partner labels Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @maximbaibakov. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2747 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@maximbaibakov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@gwharton
Copy link
Contributor

gwharton commented Aug 12, 2018

This will only add regions for new installs. You also need to implement the updatadata scripts so that existing installs will be altered too.

@VladimirZaets
Copy link
Contributor

@gwharton thanks for the comment.
Hi @maximbaibakov, please create update data scripts to support already existing installs.

@maximbaibakov
Copy link
Author

Hi @gwharton and @VladimirZaets

Good point! I have updated the update data scripts to include Australian regions

Regards,
Maxim

@magento-engcom-team
Copy link
Contributor

Hi @maximbaibakov. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants