[Backport] Doesn't work if use date as condition for Catalog Price Rules#17503
Closed
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-16855
Closed
[Backport] Doesn't work if use date as condition for Catalog Price Rules#17503mage2pratik wants to merge 1 commit intomagento:2.1-developfrom mage2pratik:2.1-develop-PR-port-16855
mage2pratik wants to merge 1 commit intomagento:2.1-developfrom
mage2pratik:2.1-develop-PR-port-16855
Conversation
Contributor
|
Hi @mage2pratik , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.1 release line. We can accept fixes for known bugs only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#16855
Description
Fix following issue:
Doesn't work if use date as condition for Catalog Price Rules.
Manual testing scenarios
add or edit a Rule, then if use date as a condition, that condition doesn't work.
Contribution checklist